Repository navigation
Conversation
`dateutil.zoneinfo` is deprecated in version 3.0+, but it turns out that this test is not actually *using* dateutil in any meaningful way, because it takes the union of the dateutil zones and the zoneinfo zones, and then discards all the ones that are not in the zoneinfo set, which is equivalent to just using the zoneinfo zones directly. So, I've simply removed the deprecated zoneinfo usage.
pganssle
commented
Oct 22, 2026
| def make_full_tz_list(): | ||
| dateutil_zones = set(get_zonefile_instance().zones) | ||
| zoneinfo_zones = set(zoneinfo.available_timezones()) | ||
| # Since the tests create ZoneInfo objects, we can only use timezones |
Contributor
Author
There was a problem hiding this comment.
Let me know if you would prefer that I remove this comment, it's mostly not relevant now that there's no other option to contrast it with.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1392 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
-[x] 🛠️ All tests pass when run locally (run
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.Description of Changes
dateutil.zoneinfois deprecated in version 3.0+, but it turns out that this test is not actually using dateutil in any meaningful way, because it takes the union of the dateutil zones and the zoneinfo zones, and then discards all the ones that are not in the zoneinfo set, which is equivalent to just using the zoneinfo zones directly.So, I've simply removed the deprecated zoneinfo usage.